The Wayback Machine - https://web.archive.org/web/20201004035112/https://github.com/GoogleCloudPlatform/magic-modules/pull/4040
Skip to content

/ magic-modules

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream https://github.com/hashicorp/terraform-provider-google/pull/7349 #4040

Open
wants to merge 1 commit into
base: master
from
Open

Upstream https://github.com/hashicorp/terraform-provider-google/pull/7349 #4040

wants to merge 1 commit into from

Conversation

@ndmckinley
Copy link
Member

@ndmckinley ndmckinley commented Oct 1, 2020

Update docs for appengine IAP.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)
@ndmckinley
Upstream hashicorp/terraform-provider-google#7349
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
143aa17
@ndmckinley ndmckinley requested a review from megan07 Oct 1, 2020
@google-cla google-cla bot added the cla: yes label Oct 1, 2020
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Oct 1, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 3 insertions(+))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+))
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Oct 1, 2020

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=149843"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
2 participants
@ndmckinley @modular-magician
You can’t perform that action at this time.