The Wayback Machine - https://web.archive.org/web/20201004035134/https://github.com/GoogleCloudPlatform/magic-modules/pull/4023
Skip to content

/ magic-modules

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conditions to Cloud Asset Feeds #4023

Open
wants to merge 2 commits into
base: master
from
Open

Added conditions to Cloud Asset Feeds #4023

wants to merge 2 commits into from
+126 −0

Conversation

@apsureda
Copy link
Contributor

@apsureda apsureda commented Sep 27, 2020

Added conditions to Cloud Asset Inventory feeds.
Conditions were recently added to the API:
https://cloud.google.com/asset-inventory/docs/reference/rest/v1/feeds#Feed
https://cloud.google.com/asset-inventory/docs/reference/rest/Shared.Types/Expr

Fixes hashicorp/terraform-provider-google#7364

If this PR is for Terraform, I acknowledge that I have:

  • [ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_asset: Added `condition` to `google_cloud_asset_organization_feed`
cloud_asset: Added `condition` to `google_cloud_asset_folder_feed`
cloud_asset: Added `condition` to `google_cloud_asset_project_feed`
apsureda added 2 commits Sep 27, 2020
@apsureda
Merge pull request #1 from GoogleCloudPlatform/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6e4ab23 
Updating to latest changes in magic modiles repo
@apsureda
Added conditions block to asset feeds
Loading status checks…
c4c968d
@google-cla google-cla bot added the cla: yes label Sep 27, 2020
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 27, 2020

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.
@modular-magician modular-magician requested a review from slevenick Sep 27, 2020
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 27, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 585 insertions(+))
Terraform Beta: Diff ( 9 files changed, 585 insertions(+))
TF Conversion: Diff ( 3 files changed, 186 insertions(+))
@slevenick
Copy link
Collaborator

@slevenick slevenick commented Sep 28, 2020

/gcbrun
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 28, 2020

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=149158"
@modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 28, 2020

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 585 insertions(+))
Terraform Beta: Diff ( 9 files changed, 585 insertions(+))
TF Conversion: Diff ( 3 files changed, 186 insertions(+))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
3 participants
@apsureda @modular-magician @slevenick
You can’t perform that action at this time.