The Wayback Machine - https://web.archive.org/web/20201018182130/https://github.com/validatorjs/validator.js/issues/1068
Skip to content

/ validator.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute: Add more locale #1068

Open
nyinyinyanlin opened this issue Jul 22, 2019 · 6 comments
Open

Contribute: Add more locale #1068

nyinyinyanlin opened this issue Jul 22, 2019 · 6 comments
Labels
good first issue 🙋‍♂️feature-request

Comments

@nyinyinyanlin
Copy link

@nyinyinyanlin nyinyinyanlin commented Jul 22, 2019

I want to add locale support for Burmese, Myanmar. (my_MM) How can I contribute? Would appreciate some guidelines and how-to to follow.
@ezkemboi
Copy link
Contributor

@ezkemboi ezkemboi commented Jul 23, 2019

@nyinyinyanlin check on README.md on Contributing section.
When contributing, also, please add tests and run them locally.

PR welcomed.

Thank you.
@profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Jul 24, 2019

Sure, if you need any specific help, feel free to reach out to either myself or @ezrqnkemboi
@nyinyinyanlin
Copy link
Author

@nyinyinyanlin nyinyinyanlin commented Jul 31, 2019

Sorry for a late reply. Thanks to both of you. I will start digging the code.

Should I close this or leave open for future communication?
@ezkemboi
Copy link
Contributor

@ezkemboi ezkemboi commented Jul 31, 2019

Do not close @nyinyinyanlin.
It will be closed when we have a PR raised and the issue solved/merged or discussion ended.
I don't know if it makes some sense.
@rubiin
Copy link
Contributor

@rubiin rubiin commented Oct 1, 2019 •
edited

if its still unresolved, i can take it @ezkemboi i could tally up the current data with various sources and add if we are missing out something
@pedramp
Copy link
Contributor

@pedramp pedramp commented Oct 2, 2019 •
edited

@profnandaa, @ezkemboi Added PR #1121 for Farsi(fa-IR) language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🙋‍♂️feature-request
5 participants
@pedramp @profnandaa @rubiin @nyinyinyanlin @ezkemboi
You can’t perform that action at this time.