The Wayback Machine - https://web.archive.org/web/20200918123429/https://github.com/ml5js/ml5-library/issues/647
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Doc using hash router #647

Open
DaKoala opened this issue Oct 19, 2019 · 1 comment
Open

[documentation] Doc using hash router #647

DaKoala opened this issue Oct 19, 2019 · 1 comment

Comments

@DaKoala
Copy link

@DaKoala DaKoala commented Oct 19, 2019

It seems that the doc website is using a router in hash mode. For example, URL of the index of the reference section is https://learn.ml5js.org/docs/#/reference/index. There is a hash tag "#" in the URL.

This may make it a little obfuscating for people who want to memorize the link and share it with others.

I recommend changing the router from hash mode to history mode to remove the ugly hash tag.

@joeyklee joeyklee changed the title Doc using hash router [documentation] Doc using hash router Feb 19, 2020
@sourabhR4ikwar
Copy link

@sourabhR4ikwar sourabhR4ikwar commented May 20, 2020

I'd like to help with this issue. I am new to open source contribution. this is my first issue. I found the solution for this problem on docsify documentation. I would like to implement it. I think this will get the work done.

Docsify_Router

sourabhR4ikwar added a commit to sourabhR4ikwar/ml5-library that referenced this issue May 20, 2020
sourabhR4ikwar added a commit to sourabhR4ikwar/ml5-library that referenced this issue May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.