The Wayback Machine - https://web.archive.org/web/20200606061526/https://github.com/chartjs/Chart.js/pull/6555
Skip to content

/ Chart.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel plugin for rollup & transform code #6555

Merged
merged 2 commits into from Oct 27, 2019
Merged

Add babel plugin for rollup & transform code #6555

merged 2 commits into from Oct 27, 2019

Conversation

@etimberg
Copy link
Member

etimberg commented Oct 6, 2019

Adds the babel rollup plugin to enable moving the codebase to ES6+.

I did not configure the preset targets yet. We can do that once we decide what exactly we want to support.
@etimberg etimberg requested a review from benmccann Oct 6, 2019
@benmccann
Copy link
Collaborator

benmccann commented Oct 7, 2019

@etimberg I don't have any major objections to this since we already need to compile the code to run it, but I know that @simonbrunel had wanted to wait until v3. See #5787 (comment)
@etimberg
Copy link
Member Author

etimberg commented Oct 7, 2019

Perhaps we should leave this until after 2.9 and then make the next version v3? Seems like we've got a long list of stuff to do
@benmccann benmccann mentioned this pull request Oct 10, 2019
Closed
@rwwagner90
Copy link

rwwagner90 commented Oct 10, 2019

Very much in favor of adding babel. There should be no reason we could not enable it now. It should not break anything. If things need no transpiling, it should be a noop.
@benmccann benmccann mentioned this pull request Oct 24, 2019
Merged
@etimberg etimberg mentioned this pull request Oct 24, 2019
Open
@etimberg etimberg requested review from kurkle and benmccann and removed request for benmccann Oct 26, 2019
@etimberg etimberg added this to the Version 3.0 milestone Oct 26, 2019
@etimberg
Copy link
Member Author

etimberg commented Oct 26, 2019

@benmccann now that v2.9 is out, shall we merge this?
@benmccann
Copy link
Collaborator

benmccann commented Oct 26, 2019

I think using a .browserslistrc is preferred over targets. What do you think about adding a .browserslistrc that just uses their defaults for now? I think you just create the file and put the word "defaults" in it.

"defaults" is defined as: https://github.com/browserslist/browserslist/blob/2fee1e4d7b1bae0214bbbef10d04087a2785dfd3/index.js#L429
etimberg added 2 commits Oct 6, 2019
@etimberg
Add babel plugin for rollup & transform code
718decb
@etimberg
Add .browserlistrc file & copy defaults
Loading status checks…
93d730a
@etimberg etimberg force-pushed the etimberg:add-babel-plugin branch from bf26a54 to 93d730a Oct 26, 2019
@etimberg
Copy link
Member Author

etimberg commented Oct 26, 2019

@benmccann I added the .browserlistrc file & copied the defaults over.
@benmccann
benmccann approved these changes Oct 27, 2019
View changes
@kurkle
kurkle approved these changes Oct 27, 2019
View changes
@etimberg etimberg merged commit 1ac3a69 into chartjs:master Oct 27, 2019
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.941%
Details
@etimberg etimberg deleted the etimberg:add-babel-plugin branch Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@etimberg @benmccann @rwwagner90 @kurkle
You can’t perform that action at this time.