The Wayback Machine - https://web.archive.org/web/20201127034644/https://github.com/microsoft/react-native-macos/pull/584
Skip to content

/ react-native-macos

forked from facebook/react-native
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ado] Get rid of trailing quote in npm dist-tag #584

Merged
merged 1 commit into from Sep 8, 2020
Merged

[ado] Get rid of trailing quote in npm dist-tag #584

merged 1 commit into from Sep 8, 2020

Conversation

@alloy
Copy link
Member

@alloy alloy commented Sep 8, 2020 •
edited by msftbot bot

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

While the docs give an example of using a plain script task, I couldn't get the trailing quote to be gone. The only way appears to be to use a bash script.

Also filed a ADO doc PR MicrosoftDocs/azure-devops-docs#9235

Microsoft Reviewers: Open in CodeFlow
@alloy
[ado] Get rid of trailing quote in npm dist-tag
Loading status checks…
157bc6d 
The only way appears to be to use a bash script.
@alloy alloy requested a review from tom-un as a code owner Sep 8, 2020
@alloy
Copy link
Member Author

@alloy alloy commented Sep 8, 2020

This is the problem:

Screenshot 2020-09-08 at 16 07 21
@tom-un
tom-un approved these changes Sep 8, 2020
View changes
@alloy alloy mentioned this pull request Sep 8, 2020
Merged
@alloy
Copy link
Member Author

@alloy alloy commented Sep 8, 2020 •
edited

Hmm, is there a difference between creating a PR to master and e.g. the 0.62-stable branch?

It looks like PR'ing into the 0.62-stable branch leads to trying to trigger more Circle CI checks, one of which requires a macOS image and because our trial run is over the pipeline gets blocked:

Screenshot 2020-09-08 at 16 26 51
@tom-un
tom-un approved these changes Sep 8, 2020
View changes
@alloy alloy merged commit 4cf1d19 into 0.62-stable Sep 8, 2020
6 of 7 checks passed
6 of 7 checks passed
ci/circleci: setup_ios Your tests have been scheduled to run again
Details
ci/circleci: analyze_code Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup_js Your tests passed on CircleCI!
Details
ci/circleci: test_js Your tests passed on CircleCI!
Details
ci/circleci: test_js_lts Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
@alloy alloy deleted the fix-tag-name-on-stable-branch branch Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@alloy @tom-un
You can鈥檛 perform that action at this time.