Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Replace DWORDXX with IMAGE_THUNK_DATAXX. #112
Conversation
|
|
|
@bgianfo done |
|
Looks like your branch for patch-4 is still behind ~20 commits, missing the new PR Valdation. |
|
My bad, I updated something else by mistake. I rebased again here. Also, what PR validation did you mean? LMK if anything is missing. Thanks |
Looks like it caught a build failure. |
|
Did you mean to use |
lironzua
force-pushed the
lironzua:patch-4
branch
5 times, most recently
from
f01b7ab
to
6195b56
Since both of the types have the same capacity in the same arch, they both work. But IMAGE_THUNK_DATAXX is the right struct for this code and I believe to make the code more readable and descriptive.