The Wayback Machine - https://web.archive.org/web/20201007235440/https://github.com/apache/shardingsphere/issues/7522
Skip to content

/ shardingsphere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance test cases for TextProtocolBackendHandlerFactory #7522

Open
terrymanu opened this issue Sep 19, 2020 · 2 comments
Open

Enhance test cases for TextProtocolBackendHandlerFactory #7522

terrymanu opened this issue Sep 19, 2020 · 2 comments
Assignees
@sluk3r
Labels
good first issue in: test
Milestone
5.0.0-alpha

Comments

@terrymanu
Copy link
Member

@terrymanu terrymanu commented Sep 19, 2020 •
edited

The class TextProtocolBackendHandlerFactory has already split into multiple Factory classes. It is better to split test cases into suitable classes.

  • Move TCL related test cases into TransactionBackendHandlerFactoryTest
  • Keep one TCL SQL test case in TextProtocolBackendHandlerFactoryTest and assert return TransactionBackendHandler
  • Move DAL related test cases into DALBackendHandlerFactoryTest
  • Keep one DAL SQL test case in TextProtocolBackendHandlerFactoryTest and assert return UnicastBackendHandler
  • Add test cases for RDL (3 branches) in TextProtocolBackendHandlerFactoryTest
  • Add test case for MySQLShowTablesStatement in DALBackendHandlerFactoryTest
  • Add test case for CommitStatement in TransactionBackendHandlerFactoryTest
  • Add test case for RollbackStatement in TransactionBackendHandlerFactoryTest
  • Add test case for return BroadcastBackendHandler in TransactionBackendHandlerFactoryTest
@terrymanu terrymanu added this to the 5.0.0-alpha milestone Sep 19, 2020
@sluk3r
Copy link
Contributor

@sluk3r sluk3r commented Sep 19, 2020

please assign it to me
@menghaoranss
Copy link
Contributor

@menghaoranss menghaoranss commented Sep 21, 2020

@sluk3r Assigned.
@sluk3r sluk3r mentioned this issue Sep 21, 2020
Merged
@terrymanu terrymanu reopened this Sep 21, 2020
@sluk3r sluk3r mentioned this issue Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue in: test
3 participants
@terrymanu @sluk3r @menghaoranss
You can’t perform that action at this time.