The Wayback Machine - https://web.archive.org/web/20200928173936/https://github.com/hackmdio/codimd/issues/1341
Skip to content

/ codimd

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS style unreadable for Mermaid dark mode #1341

Open
917huB opened this issue Nov 10, 2019 · 1 comment
Open

CSS style unreadable for Mermaid dark mode #1341

917huB opened this issue Nov 10, 2019 · 1 comment
Labels
good first issue night theme renderer

Comments

@917huB
Copy link

@917huB 917huB commented Nov 10, 2019

Looks fine in light mode, text unreadable in dark mode.
UML-dark
UML-light
@Yukaii
Copy link
Member

@Yukaii Yukaii commented Nov 12, 2019

Thanks for firing up this issue. After some investigations, I found that it consists of 2 issues:

  1. The mermaid stylesheet is outdated. Mermaid now embed styles inline when generating svg. This stylesheet should be removed (from our webpack config).
  2. Night mode implementation for mermaid is also outdated. Latest mermaid provides 4 different themes. We should feed in mermaid theme option based on current theme, and then trigger a rerender.

    codimd/public/js/extra.js

    Line 397 in 558fa5f

    window.mermaid.init(undefined, $ele)

Ref: https://stackoverflow.com/questions/49535327/change-mermaid-theme-in-markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue night theme renderer
2 participants
@Yukaii @917huB
You can’t perform that action at this time.