The Wayback Machine - https://web.archive.org/web/20201020035555/https://github.com/writeas/writefreely/issues/340
Skip to content

/ writefreely

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta tags are double html-encoded #340

Closed
thebaer opened this issue Jul 28, 2020 · 1 comment
Closed

Meta tags are double html-encoded #340

thebaer opened this issue Jul 28, 2020 · 1 comment
Labels
bug good first issue help wanted
Milestone
0.13

Comments

@thebaer
Copy link
Member

@thebaer thebaer commented Jul 28, 2020 •
edited

Describe the bug

If you check the HTML source on this post, the HTML tags are double HTML encoded. For example:

<meta property="og:description" content="Unless you&amp;#39;ve been hiding under a rock the last week or so, you probably know that Twitter got &amp;#34;hacked&amp;#34;. So, is Mastodon immu..." />

Expected behavior

The &amp;#34; should be &#34;

Application configuration

  • Single mode or Multi-user mode? multi-user
  • Database? n/a
  • Open registration? n/a
  • Federation enabled? n/a

Version or last commit: v0.12
@thebaer thebaer added this to the 0.13 milestone Jul 28, 2020
@Obayanju
Copy link
Contributor

@Obayanju Obayanju commented Aug 8, 2020

I think you meant &#39; for a single quote since the linked post uses a single quote.
Antolius added a commit to Antolius/writefreely that referenced this issue Sep 4, 2020
@Antolius
Fix escaping in post summary
7f1302b 
Unescaping post content after sanitizing it. This will prevent double
escaping when summary is rendered by html/template package which does
escaping by default.
Fixes writeas#340
Antolius added a commit to Antolius/writefreely that referenced this issue Sep 5, 2020
@Antolius
Fix escaping in post summary
eb76faa 
Unescaping post content after sanitizing it. This will prevent double
escaping when summary is rendered by html/template package which does
escaping by default.
Fixes writeas#340
@Antolius Antolius mentioned this issue Sep 5, 2020
Merged
1 of 1 task complete
@thebaer thebaer closed this in #382 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue help wanted
2 participants
@thebaer @Obayanju
You can’t perform that action at this time.