The Wayback Machine - https://web.archive.org/web/20200921065011/https://github.com/strukturag/libheif/pull/309
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence possible integer conversion warnings #309

Merged

Conversation

@lovell
Copy link
Contributor

lovell commented Sep 7, 2020

Prevents the following compiler warnings:

heif_context.cc: In function 'std::shared_ptr<heif::HeifPixelImage> create_alpha_image_from_image_alpha_channel(std::shared_ptr<heif::HeifPixelImage>)':

heif_context.cc:1623:48: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
 1623 |   alpha_image->fill_new_plane(heif_channel_Cb, half_range, chroma_width, chroma_height, bpp);
      |                                                ^~~~~~~~~~

heif_context.cc:1624:48: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion]
 1624 |   alpha_image->fill_new_plane(heif_channel_Cr, half_range, chroma_width, chroma_height, bpp);
      |                                                ^~~~~~~~~~
@farindk farindk merged commit ea0fb40 into strukturag:master Sep 7, 2020
28 checks passed
28 checks passed
build (nothing)
Details
build (nothing)
Details
emscripten
Details
fuzzer
Details
libde265 (1)
Details
cpplint
Details
mingw (32)
Details
build (nothing)
Details
test
Details
build (cmake, 1, 1, 1, 1, 1)
Details
build (libde265 (1) / x265 / aom / graphics, 1, 1, 1, 1)
Details
libde265 (2)
Details
mingw (64)
Details
build (cmake, 1, 1, 1, 1, 1)
Details
build (tarball, 1, 1, 1, 1, 1)
Details
build (libde265 (2) / x265 / aom / graphics, 1, 1, 1, 2)
Details
build (libde265 (1) / x265 / graphics, 1, 1, 1)
Details
build (graphics, 1)
Details
build (libde265 (2) / x265 / graphics, 1, 1, 2)
Details
build (x265, 1)
Details
build (x265 / graphics, 1, 1)
Details
build (libde265 (1) / graphics, 1, 1)
Details
build (libde265 (2) / graphics, 1, 2)
Details
build (libde265 (1) / x265 / graphics, 1, 1, 1)
Details
build (libde265 (2) / x265 / graphics, 1, 1, 2)
Details
build (libde265 (1) / x265 / aom / graphics, 1, 1, 1, 1)
Details
licenses
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@farindk
Copy link
Contributor

farindk commented Sep 7, 2020

Thanks.

@lovell lovell deleted the lovell:heif-context-alpha-half-range-conversion branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.