The Wayback Machine - https://web.archive.org/web/20200926113520/https://github.com/pytest-dev/pytest-html/pull/276
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use importlib.resources instead of setuptools for loading css and js #276

Open
wants to merge 2 commits into
base: master
from

Conversation

@jmrgibson
Copy link

jmrgibson commented Mar 3, 2020

Fixes: #275

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Mar 3, 2020

Hi! Mind describing why this is good? Or at least add a Fixes tag/mention/link. 👍

Also, tests are failing. :)

@jmrgibson
Copy link
Author

jmrgibson commented Mar 3, 2020

Sorry, I'm not super familiar with the GH interface. The issue is here: #276 (comment)
It doesn't look like I have permission to add linked issues to this PR?

Looking at the tests now...

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Mar 3, 2020

No worries, I edited the main description/comment with a common way of linking.

Basically what you did in the comment above. :) @jmrgibson

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Mar 3, 2020

@jmrgibson
Copy link
Author

jmrgibson commented Mar 3, 2020

Bah, importlib was added in 3.1, but importlib.resources is only available in 3.7. I could make the selection of pkg_resources vs importlib.resources determined at runtime based on the version, can you please take a look at the rational in the linked issue, and let me know if you think it's worth adding? Otherwise I'll just maintain my own fork (I'm running 3.7 in pyoxidize).

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Mar 3, 2020

Ok, I'll dive a little deeper into this in the coming days. Ping me next week if you haven't heard anything. 👍

@jmrgibson jmrgibson force-pushed the jmrgibson:master branch from 5b853b0 to 39d9560 Mar 3, 2020
@jmrgibson
Copy link
Author

jmrgibson commented Mar 19, 2020

Pinging @BeyondEvil :) Hope you aren't too affected by COVID-19, did you get a chance to look at importlib.resources?

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Mar 19, 2020

Actually, the whole family has been sick. Still are even. Not Covid19 tho. I think, haha.

So haven't had a chance yet, but will get to it.

@ssbarnea ssbarnea added the bug label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.