Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Merge Dxl test #596
Merged
Merge Dxl test #596
Conversation
Grbl_Esp32/src/Motors/Dynamixel2.cpp
Outdated
| @@ -226,6 +238,8 @@ namespace Motors { | |||
| //int32_t pos_min_steps, pos_max_steps; // in steps | |||
| //int32_t dxl_position, dxl_count_min, dxl_count_max; | |||
|
|
|||
| //grbl_msg_sendf(CLIENT_SERIAL, MSG_LEVEL_INFO, "Read position"); | |||
MitchBradley
Sep 15, 2020
Collaborator
MsgLevel::Info or delete line
MsgLevel::Info or delete line
Grbl_Esp32/src/Motors/Dynamixel2.cpp
Outdated
|
|
||
| return dxl_position; | ||
| } else { | ||
| grbl_msg_sendf(CLIENT_SERIAL, MsgLevel::Info, "Data len arror: %d", data_len); | ||
| //grbl_msg_sendf(CLIENT_SERIAL, MSG_LEVEL_INFO, "Data len arror: %d", data_len); |
MitchBradley
Sep 15, 2020
Collaborator
MsgLevel::Info or delete line
MsgLevel::Info or delete line
Grbl_Esp32/src/Motors/Dynamixel2.cpp
Outdated
| @@ -348,6 +366,8 @@ namespace Motors { | |||
| uint8_t count = 0; | |||
| uint8_t current_id; | |||
|
|
|||
| //grbl_msg_sendf(CLIENT_SERIAL, MSG_LEVEL_INFO, "dxl_bulk_goal_position() "); | |||
MitchBradley
Sep 15, 2020
Collaborator
MsgLevel::Info or delete line
MsgLevel::Info or delete line
Grbl_Esp32/src/System.cpp
Outdated
| uint8_t pin = system_control_get_state(); | ||
| if (pin) { | ||
| system_exec_control_pin(pin); | ||
| // this is the debounce task |
MitchBradley
Sep 15, 2020
Collaborator
Possible spurious indentation here to end of file.
Possible spurious indentation here to end of file.
|
Approved subject to formatting cleanups |
Grbl_Esp32/src/System.cpp
Outdated
| return (steps[A_MOTOR] + steps[B_MOTOR]) / 2; | ||
| } | ||
| // CoreXY calculation only. Returns x or y-axis "steps" based on CoreXY motor steps. | ||
| int32_t system_convert_corexy_to_x_axis_steps(int32_t * steps) { return (steps[A_MOTOR] + steps[B_MOTOR]) / 2; } |
MitchBradley
Sep 15, 2020
Collaborator
Is this and the following definition really meant to be on one line?
Is this and the following definition really meant to be on one line?
atlaste
pushed a commit
to atlaste/Grbl_Esp32
that referenced
this pull request
Oct 13, 2020
* Changes, not ready yet * Some updates for M67 * WIP * Updates * Code cleanup and speed tweaks * Prep for PR * Cleaned up user I/O to use UNDEFINED_PIN as defaults. * Cleaned up spurious code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes to
New
Some cleanup