The Wayback Machine - https://web.archive.org/web/20200919231504/https://github.com/apache/avro/pull/922
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example map definition #922

Open
wants to merge 1 commit into
base: master
from
Open

Correct example map definition #922

wants to merge 1 commit into from

Conversation

@ksunden
Copy link

ksunden commented Jul 2, 2020

The key for maps is not items, as it is for arrays, but values

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does
The key for maps is not `items`, as it is for arrays, but `values`
@probot-autolabeler probot-autolabeler bot added the website label Jul 2, 2020
@ksunden ksunden mentioned this pull request Jul 11, 2020
0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.