Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #137: Add SuccessExitCode to ManifestInstaller #296
Conversation
… code
chausner
requested a review
from microsoft/windows-package-manager-admins
as a
code owner
|
We have a manifest versioning strategy that isn't really mature in the codebase yet, but we want to ensure we build that muscle/work out the kinks. So any new additions to the manifest would need increment the manifest version and be interpreted appropriately. In addition, I think we probably do want to support multiple exit codes for success. While the uses are probably low, it would be better to support it from the beginning than to have a versioning problem later on. But this kind of thing is best worked out in a spec (which I think we need to document the process better). See https://github.com/microsoft/winget-cli/projects/1 |
|
Thank you for your feedback. I'd be happy to make changes once the spec is finalized and the details have been clarified. |
|
@JohnMcPMS The canonical example that comes to mind are the "pseudo-success" codes that are returned for installs that require a reboot to complete:
|
This PR suggests a fix for #137 by adding an optional
SuccessExitCodeattribute to the Installers entries in the manifest. If present, it overrides the default value of zero.For now, this only allows a single value to be defined as success status code. I am not sure if there are cases where we would want multiple exit codes to count as success.
Right now, SuccessExitCode is not printed by the "show" command but we could add it if desired.
Microsoft Reviewers: Open in CodeFlow