The Wayback Machine - https://web.archive.org/web/20201223164555/https://github.com/tinygo-org/tinygo/issues/1343
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf: I2C Tx() fails on NACK #1343

Closed
dmlambea opened this issue Sep 2, 2020 · 3 comments
Closed

nrf: I2C Tx() fails on NACK #1343

dmlambea opened this issue Sep 2, 2020 · 3 comments
Labels

Comments

@dmlambea
Copy link
Contributor

@dmlambea dmlambea commented Sep 2, 2020

The i2c.readByte has no checks for error conditions. This makes the function to loop forever if receiving a NACK instead of an ACK.

@deadprogram
Copy link
Member

@deadprogram deadprogram commented Sep 12, 2020

Hello @dmlambea thanks for reporting this. Are you able to submit a PR with a fix for this?

@dmlambea
Copy link
Contributor Author

@dmlambea dmlambea commented Sep 17, 2020

Yes, @deadprogram. Hopefully, today.

@deadprogram
Copy link
Member

@deadprogram deadprogram commented Nov 24, 2020

This was released as part of v0.16.0 so now closing. Thank you @dmlambea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.