The Wayback Machine - https://web.archive.org/web/20220323011104/https://github.com/nodejs/node/pull/35202
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add wasi readdir() test #35202

Closed
wants to merge 1 commit into from
Closed

test: add wasi readdir() test #35202

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 15, 2020

This commit provides coverage for __wasi_fd_readdir().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@cjihrig
test: add wasi readdir() test
3f040fc 
This commit provides coverage for __wasi_fd_readdir().
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 15, 2020

Review requested:
@nodejs-github-bot nodejs-github-bot added the test label Sep 15, 2020
@gengjiawen gengjiawen added the wasi label Sep 16, 2020
@gengjiawen gengjiawen added the request-ci label Sep 16, 2020
@github-actions github-actions bot removed the request-ci label Sep 16, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Sep 16, 2020 •
edited by cjihrig

CI: https://ci.nodejs.org/job/node-test-pull-request/33146/ 💚
@cjihrig cjihrig added author ready commit-queue labels Sep 16, 2020
@github-actions github-actions bot removed the commit-queue label Sep 17, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Sep 17, 2020

Landed in c314c04
nodejs-github-bot added a commit that referenced this issue Sep 17, 2020
@cjihrig @nodejs-github-bot
test: add wasi readdir() test
c314c04 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@github-actions github-actions bot closed this Sep 17, 2020
@cjihrig cjihrig deleted the readdir branch Sep 17, 2020
ruyadorno added a commit that referenced this issue Sep 21, 2020
@cjihrig @ruyadorno
test: add wasi readdir() test
8357b56 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
MylesBorins added a commit that referenced this issue Nov 3, 2020
@cjihrig @MylesBorins
test: add wasi readdir() test
eb33501 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins added a commit that referenced this issue Nov 16, 2020
@cjihrig @MylesBorins
test: add wasi readdir() test
c3e1bf7 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
joesepi added a commit to joesepi/node that referenced this issue Jan 8, 2021
@cjihrig @joesepi
test: add wasi readdir() test
6fa7864 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: nodejs#35202
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready test wasi
5 participants
@cjihrig @nodejs-github-bot @addaleax @gengjiawen @devsnek