src: add get/set pair for env context awareness #35024
Closed
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
devsnek
approved these changes
Sep 2, 2020
joyeecheung
approved these changes
Sep 2, 2020
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Sep 2, 2020
codebytere
added
the
author ready
|
Landed in 89f2d46 |
codebytere
added a commit
that referenced
this issue
Sep 4, 2020
PR-URL: #35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Sep 7, 2020
PR-URL: #35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
pushed a commit
that referenced
this issue
Sep 7, 2020
PR-URL: #35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
PR-URL: #35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this issue
Sep 22, 2020
PR-URL: #35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this issue
Jan 8, 2021
PR-URL: nodejs#35024 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds in a getter/setter pair for forcing context awareness of native Node.js modules within
Environment.Electron wants to force this in our initialization logic for the Renderer process (e.g outside the context of spawning a process), and this helps us by removing a patch that added this in.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes