The Wayback Machine - https://web.archive.org/web/20200914220549/https://github.com/TheAlgorithms/Python/pull/2417
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recaptchaVerification #2417

Merged
merged 19 commits into from Sep 13, 2020
Merged

recaptchaVerification #2417

merged 19 commits into from Sep 13, 2020
+66 −0

Conversation

@santoshrajkumar
Copy link
Contributor

santoshrajkumar commented Sep 12, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@santoshrajkumar
recaptchaVerification
Loading status checks…
d6f764b
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 86a95150-f4b6-11ea-aaf4-7d25d946cae2
@cclauss
Copy link
Member

cclauss commented Sep 12, 2020 •
edited

Cool submission! The Travis tests are failing so please see CONTRIBUTING.md discussion of black and flake8 and variable naming.

https://travis-ci.com/github/TheAlgorithms/Python/builds/184017264
@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 12, 2020

Cool submission! The Travis tests are failing so please see CONTRIBUTING.md discussion of black and flake8 and variable naming.

https://travis-ci.com/github/TheAlgorithms/Python/builds/184017264

Shall look into it. Being part of na back end code, there may be issues coming up.
@santoshrajkumar
recaptchaVerification
Loading status checks…
d27fe09
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0692f490-f4ba-11ea-aaf4-7d25d946cae2
@cclauss
Copy link
Member

cclauss commented Sep 12, 2020 •
edited

https://travis-ci.com/github/TheAlgorithms/Python/builds/184018231#L294-L307

Most of these can be autofixed by running black on your code.
@santoshrajkumar
recaptchaVerification1
Loading status checks…
e0c8abc
@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 12, 2020 •
edited

https://travis-ci.com/github/TheAlgorithms/Python/builds/184018231#L294-L307

Most of these can be autofixed by running black on your code.

Ran black on the code & repushed.
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 14851ba0-f4bf-11ea-aaf4-7d25d946cae2
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@santoshrajkumar
recaptchaVerification2
Loading status checks…
c0ab086
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@santoshrajkumar
recaptchaVerification3
Loading status checks…
e238701
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 17b56210-f4c1-11ea-aaf4-7d25d946cae2
@santoshrajkumar
santoshrajkumar reviewed Sep 12, 2020
View changes
Copy link
Contributor Author

santoshrajkumar left a comment

tried to resolve in the latest commit
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a756f1e0-f4c1-11ea-aaf4-7d25d946cae2
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated
verify = response["success"]

# if verify is true
if verify == True:

This comment has been minimized.

Sign in to view
@cclauss

cclauss Sep 12, 2020

Member

See PEP8...

Suggested change
if verify == True:
if verify:
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@santoshrajkumar
recaptchaVerification4
Loading status checks…
d120d8c
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated
return render(request, "login.html")
else:
# if verify is not true, send user back to login page
return render(request, "login.html")

This comment has been minimized.

Sign in to view
@cclauss

cclauss Sep 12, 2020 •
edited

Member
Suggested change
return render(request, "login.html")
return render(request, "login.html")

That ⛔ sign is because the GitHub editor knows that Python files end with one and only one \n.
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 14c57140-f4c5-11ea-aaf4-7d25d946cae2
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@santoshrajkumar
recaptchaVerificatio5
Loading status checks…
9c2f389
@santoshrajkumar
recaptchaVerificatio6
Loading status checks…
7311e4e
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9ffc7e30-f4c9-11ea-aaf4-7d25d946cae2
@santoshrajkumar
drawOnVideoStreamOpenCV
Loading status checks…
26b90fb
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 30234390-f4ca-11ea-aaf4-7d25d946cae2
@cclauss
cclauss reviewed Sep 12, 2020
View changes
computer_vision/draw_on_webcam_video_stream.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Sep 12, 2020
View changes
web_programming/recaptcha_verification.py Outdated Show resolved Hide resolved
@santoshrajkumar
matrixInverseMCAmethod
Loading status checks…
3690d85
@santoshrajkumar
fixingImports
Loading status checks…
64ccb63
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a75eeab0-f4cd-11ea-aaf4-7d25d946cae2
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e090f210-f4cd-11ea-aaf4-7d25d946cae2
@cclauss
cclauss requested changes Sep 12, 2020
View changes
Copy link
Member

cclauss left a comment

Please get Travis to be green...
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
@santoshrajkumar
recaptchaVerificationfixes
Loading status checks…
ad3eeaa
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 28fe7b50-f4d1-11ea-aaf4-7d25d946cae2
@santoshrajkumar
recaptchaVerificationfixes
Loading status checks…
8cf1c3d
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d8d4fa40-f4d1-11ea-aaf4-7d25d946cae2
@santoshrajkumar
recaptchaVerificationfixes
Loading status checks…
1ec029b
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e4e2f4d0-f4d2-11ea-aaf4-7d25d946cae2
@santoshrajkumar
recaptchaVerificationfixes
Loading status checks…
1852db7
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Travis tests have failed

Hey @santoshrajkumar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 114378a0-f4d4-11ea-aaf4-7d25d946cae2
@santoshrajkumar
recaptchaVerificationfixes1
Loading status checks…
7172108
@TravisBuddy
Copy link

TravisBuddy commented Sep 12, 2020

Hey @santoshrajkumar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e0251740-f4d5-11ea-aaf4-7d25d946cae2
@santoshrajkumar
recaptchaVerificationfixes1
Loading status checks…
a8b2810
@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 12, 2020 •
edited

Please get Travis to be green...
https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md

Travis tests have been passed, modified bit to make it pass.
@santoshrajkumar santoshrajkumar requested a review from cclauss Sep 12, 2020
@cclauss
authenticate = login = render = redirect = print
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
042e449
@cclauss
cclauss approved these changes Sep 13, 2020
View changes
@santoshrajkumar
santoshrajkumar reviewed Sep 13, 2020
View changes
Copy link
Contributor Author

santoshrajkumar left a comment

Seems nicer now !
@santoshrajkumar
Copy link
Contributor Author

santoshrajkumar commented Sep 13, 2020

May be merged if you'd like to.
@cclauss cclauss merged commit 4e5b730 into TheAlgorithms:master Sep 13, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@santoshrajkumar @TravisBuddy @cclauss
You can’t perform that action at this time.