The Wayback Machine - https://web.archive.org/web/20200914220855/https://github.com/TheAlgorithms/Python/pull/2414
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Stack #2414

Merged
merged 4 commits into from Sep 13, 2020
Merged

Updated Stack #2414

merged 4 commits into from Sep 13, 2020

Conversation

@shellhub
Copy link
Member

shellhub commented Sep 10, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shellhub and others added 2 commits Sep 10, 2020
@shellhub
* Added type hints
8a8dca5 
* Added test
* Formated code
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
f7d98be
@shellhub shellhub requested a review from cclauss Sep 10, 2020
@shellhub
Copy link
Member Author

shellhub commented Sep 10, 2020

@cclauss Please review. Thanks :)
@cclauss
cclauss reviewed Sep 10, 2020
View changes
data_structures/stacks/stack.py Outdated
if self.is_empty():
raise IndexError("pop from an empty stack")
Comment on lines 29 to 30

This comment has been minimized.

Sign in to view
@cclauss

cclauss Sep 10, 2020

Member

Does it do exactly the same thing if you remove lines 29 and 30?
@cclauss
cclauss reviewed Sep 10, 2020
View changes
data_structures/stacks/stack.py Outdated
if self.is_empty():
raise IndexError("peek from an empty stack")
Comment on lines 35 to 36

This comment has been minimized.

Sign in to view
@cclauss

cclauss Sep 10, 2020

Member

Does it do a similar thing if you remove lines 35 and 36?

This comment has been minimized.

Sign in to view
@shellhub

shellhub Sep 10, 2020

Author Member

Line3 35 and 36 execute when stack is empty. assert() statements will still be successful if i remove them .
@swapnanildutta
swapnanildutta approved these changes Sep 12, 2020
View changes
@TheAlgorithms TheAlgorithms deleted a comment from skyloik Sep 12, 2020
@shellhub
Copy link
Member Author

shellhub commented Sep 13, 2020

Need I update @cclauss ？
@cclauss
Update stack.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d686f88
@github-actions github-actions bot force-pushed the shellhub:dev branch from 70554c5 to d686f88 Sep 13, 2020
@shellhub
Copy link
Member Author

shellhub commented Sep 13, 2020

Thanks @cclauss . Nice updates. LGTM 👍
@cclauss
Test error conditions for pop, peek, and
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c8b2679
@cclauss
cclauss approved these changes Sep 13, 2020
View changes
@cclauss cclauss merged commit 44b8cb0 into TheAlgorithms:master Sep 13, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
@shellhub shellhub deleted the shellhub:dev branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@shellhub @cclauss @swapnanildutta
You can’t perform that action at this time.