@cclauss Please review. Thanks in advance :)

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cb2f0a90-f1af-11ea-ba41-b1d3a642fad8

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ec7590c0-f1af-11ea-ba41-b1d3a642fad8

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 18cf7a50-f1b0-11ea-ba41-b1d3a642fad8

Hey @shellhub,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3c4e1630-f1b0-11ea-ba41-b1d3a642fad8

https://travis-ci.com/github/TheAlgorithms/Python/builds/183314106#L255

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 97257ab0-f1b2-11ea-ba41-b1d3a642fad8

@cclauss why Travic CI occur error?

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d29c1380-f1b5-11ea-ba41-b1d3a642fad8

Probably trailing whitespace deleted in doctests.

How to solve？😭

See which files are failing in Travis CI and then undo the changes to those files.

Yes. I found why build error was occur. Because whitespace deleted in doctests. Should I update origin source code and commit again? have you any better suggestion? @cclauss

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5134a1b0-f1e5-11ea-ba41-b1d3a642fad8

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ece4a470-f1ea-11ea-ba41-b1d3a642fad8

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 58945cd0-f1ee-11ea-ba41-b1d3a642fad8

The build log is very difficult to understand.
It's showing all kinds of errors from OTHER files.
What is going on?
Also it says above "60 files changed" in shellhub:dev branch, was this your intention @shellhub ?
I suppose this was caused by the forced push that applied psf/black to everything?
It might be best to just start over with 1 file changed.

This was more than just running black. In the cases of the failing doctests, whitespace has been removed from the end of lines which the doctest needs to see for an exact match. This is one of the reasons why black will not suppress trailing whitespace that appears inside of triple quoted strings. There are three files that fail the Travis doctests. If the changes to those three files are reverted then the tests will pass again.

Travis tests have failed

Hey @shellhub,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c60c3520-f26c-11ea-82b8-f1691ab9f797

My sense is that you add the trailing whitespace and then the autoblack GitHub Action undoes it so the tests fail.

@cclauss All checks have passed. Can you review again. Thanks :)

I am completely lost by the change to bubble sort! We now require the user to provide length but our algorithm never uses that variable.

I am completely lost by the change to bubble sort! We now require the user to provide length but our algorithm never uses that variable.

Not exactly. length is optional to user. And we used length in our recursion code.

return list_data if not swapped else bubble_sort(list_data, length - 1)

Get a maximum value to the end of list for each recursive call. Then recursion sort left elements (length - 1 elements)

Please look at it again. Passing a number around but not actually using it (outside of decrementing it and passing it back to yourself) is a waste of cycles.

@cclauss you are right. I forget make changes that you mentioned before. I make changes like this. Please review again. Thanks :)

    length = length or len(list_data)
    swapped = False
    for i in range(length - 1):
        if list_data[i] > list_data[i + 1]:
            list_data[i], list_data[i + 1] = list_data[i + 1], list_data[i]
            swapped = True

    return list_data if not swapped else bubble_sort(list_data, length - 1)

I changed for i in range(len(list_data) - 1): to for i in range(length - 1):

OK... Here is what we are going to do. I will land this now. From now on, no PRs that touch so many files.

Please create a new PR for bubble sort that has both the old algorithm and the "oprimized" version in a single file with a timeit (or similar) benchmark that measures the relative performance of each.