The Wayback Machine - https://web.archive.org/web/20201213112419/https://github.com/nuxt/press/pull/88
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naked option #88

Open
wants to merge 2 commits into
base: develop
from
Open

fix: naked option #88

wants to merge 2 commits into from

Conversation

@shrpne
Copy link
Contributor

@shrpne shrpne commented Apr 6, 2020

{ naked: auto } doesn't work
This PR fixes it.

Considerations:

  • maybe I should pass only the naked option and not whole config?
  • core/src/blueprint/index.js, register method doesn't use config in the modeInstances initialization too, should I pass config here? Not sure if it needed for them.
@galvez galvez changed the title fix naked fix: naked option Apr 6, 2020
@galvez galvez requested a review from pimlie Apr 6, 2020
@galvez
Copy link
Member

@galvez galvez commented Apr 6, 2020

@pimlie can you answer on the second point @shrpne raises?

@shrpne
Copy link
Contributor Author

@shrpne shrpne commented Apr 6, 2020

Looks like config is really needed for modeInstances. Because without it, nuxt-press continues importing blueprint themes like docs/src/theme.css.

I have updated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.