Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix hidpi scaling on Linux #722
Open
Conversation
|
Some screenshots of the problem: In Reaper:
In Carla: |
julienpommier
commented
May 18, 2020
|
It is quite easy to reproduce with the JUCE AudioPluginDemo VST3, just build it with getDisplayScale returning 2 and load it in the AudioPluginHost. |
|
Thanks for the report! The approach that we took for Windows high DPI scaling in plug-ins was to bypass the normal scaling that happens in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
terencode commentedMay 14, 2020
@falkTX and I were trying to figure out why a VST (Pianoteq) was not displaying correctly on Carla as well as Reaper or even jalv (https://gitlab.com/drobilla/jalv) on my setup (falkTX/Carla#932) and we found the problem:
I'm on Xorg with gnome-shell and a hidpi screen (2560x1440) so
getDisplayScale()from https://github.com/juce-framework/JUCE/blob/juce6/modules/juce_gui_basics/native/x11/juce_linux_XWindowSystem.cpp#L909 returns 2. JUCE then scales the plugin accordingly but the problem is it's not notifying the host about it.So, what happened was only 1/4 of a plugin UI would be shown.
I could reproduce this with Pianoteq 6 and CHOW (https://github.com/jatinchowdhury18/CHOW) but it probably impacts all the plugins built with JUCE5/6
Once those commits are applied, the VST2/3 will need to be rebuilt and will in turn correctly work on hidpi (we tested it and confirmed working with CHOW).