The Wayback Machine - https://web.archive.org/web/20200910195558/https://github.com/pattern-lab/patternlab-node/pull/1256
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternLab only loads the pattern engines from the config #1256

Open
wants to merge 1 commit into
base: dev
from

Conversation

@ringods
Copy link
Contributor

ringods commented Sep 1, 2020

Closes #1251

Summary of changes:

  • Load the engines which are configured in the config first
  • Fallback to the old way of scanning node_modules if no engines are configured
  • Documentation added on the engines property in the PatternLab config file. URLs in the source code should point to this property once it is published during the release.
  • Proper deprecation messages should be in place.
@ringods ringods requested a review from JosefBredereck Sep 1, 2020
@ringods ringods self-assigned this Sep 1, 2020
@coveralls
Copy link

coveralls commented Sep 1, 2020

Coverage Status

Coverage decreased (-1.8%) to 75.0% when pulling 5d376a5 on feature/resolver-pattern-engines into 1d28ab0 on dev.

…llback to scanning node_modules
@ringods ringods force-pushed the feature/resolver-pattern-engines branch from 52d52ac to 5d376a5 Sep 2, 2020
@ringods ringods requested a review from raphaelokon as a code owner Sep 2, 2020
@JosefBredereck
Copy link
Contributor

JosefBredereck commented Sep 2, 2020

I can not approve that PR at the moment. The preview is not building.

Pattern Engine undefined: good to go
Found plugin: @pattern-lab/plugin-tab
Attempting to load and initialize plugin.
where is the engine?
Error rendering pattern lab header
Omitting atoms-colors from styleguide patterns because it has an underscore prefix.
where is the engine?
error during header render()
where is the engine?
error during footer render()
where is the engine?
Error building buildFooterHTML

@JosefBredereck
Copy link
Contributor

JosefBredereck commented Sep 2, 2020

When I add engine mustache, it is working. (We need to get rid of that engine to be required everywhere but it's part of the UI-kit) But it still messages:
Pattern Engine undefined: good to go
Pattern Engine undefined: good to go

[...]
    "mustache": {
      "package": "@pattern-lab/engine-mustache",
      "fileExtensions": [
        "mustache"
      ]
    }
[...]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.