Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake it possible to leave upload retries enabled #502
Merged
Conversation
| String mimeType, | ||
| String requiredEtag, | ||
| String lastModificationTimestamp, | ||
| boolean disableRetries) { |
tobiasKaminsky
Sep 7, 2020
Member
Somehow there are too many tabs, or?
Somehow there are too many tabs, or?
grote
Sep 7, 2020
Author
Member
The formatting in this library is a bit of a mess (mix of tabs and spaces) and I didn't want to auto-format everything. The above parameters seem to use spaces instead of tabs. I moved the new one to spaces as well.
The formatting in this library is a bit of a mess (mix of tabs and spaces) and I didn't want to auto-format everything. The above parameters seem to use spaces instead of tabs. I moved the new one to spaces as well.
|
master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1742-master-IT |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1742-stable-IT |
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 39.66% 39.64% -0.03%
==========================================
Files 136 136
Lines 5955 5971 +16
Branches 785 789 +4
==========================================
+ Hits 2362 2367 +5
- Misses 3236 3245 +9
- Partials 357 359 +2
|
grote
force-pushed the
upload-retries
branch
2 times, most recently
from
0c489bd
to
4a77d4a
Lint
SpotBugs (new)
SpotBugs (master)
|
|
master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1745-master-IT |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1745-stable-IT |
The retries were disabled in 0bfc385 and only for upload operations. It is not clear anymore why that happened and if that is still useful. Signed-off-by: Torsten Grote <t@grobox.de>
|
Complexity increasing per file
==============================
- src/main/java/com/owncloud/android/lib/resources/files/ChunkedFileUploadRemoteOperation.java 2
- src/main/java/com/owncloud/android/lib/resources/files/UploadFileRemoteOperation.java 2
See the complete overview on Codacy |
Lint
SpotBugs (new)
SpotBugs (master)
|
tobiasKaminsky
merged commit ccd420e
into
master
9 of 10 checks passed
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The retries were disabled in 0bfc385 and only for upload operations. It is not clear anymore why that happens and if that is still useful. This PR at least gives us the possibility to step by step experiment with retries enabled. The first use of that will be made by the DocumentsProvider's uploads.