Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupported fork fixing iOS 13 issue #300
Conversation
|
I just received an invitation from @AlexLittlejohn to update this repo. I will do my best to take care of the support, thanks to him. I will edit this MR to remove the new temporary pod repo, and add the fix you are talking about @SreejaG. Just give me a few days. |
|
Thank you for taking care of this, I've been super busy with home life such that i was not able to take care of this anymore |
This comment was marked as spam.
This comment was marked as spam.
|
@SreejaG Could you rewrite these into several issues please? I will take a look at them one by one. Feel free to submit new PR on your own also, it would go faster with some help :) |
SreejaG
commented
Oct 16, 2019
•
SreejaG
commented
Oct 16, 2019
•
|
Second Issue Found issues in iOS 12.4 :- iPad Selecting the tick icon in Confirm Screen directs to "Cancel button" action. |
SreejaG
commented
Oct 16, 2019
|
@SreejaG I meant creating issue through the issue tab which is designed for this: https://github.com/AlexLittlejohn/ALCameraViewController/issues I will close this PR soon to replace it by another one, and your informations will be lost if you don't. Thanks :) |
SreejaG
commented
Oct 16, 2019
|
Will add the issues on tomorrow
…On Wed, 16 Oct, 2019, 6:57 PM Guillaume Bellut, ***@***.***> wrote:
@SreejaG <https://github.com/SreejaG> I meant creating issue through the
issue tab which is designed for this:
https://github.com/AlexLittlejohn/ALCameraViewController/issues
I will close this PR soon to replace it by another one, and your
informations will be lost if you don't.
Thanks :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#300?email_source=notifications&email_token=AECS7ZDDDAUQODBF22BU46DQO4JDVA5CNFSM4JAHJHH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMPDJY#issuecomment-542699943>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECS7ZAZK4XO5D4IW4KYBPDQO4JDVANCNFSM4JAHJHHQ>
.
|
Thanks: I will try to fix them next week through a 3.2 version. |
3d556d8
to
2cd2215
|
@AlexLittlejohn Merge done. Could you also add me to the author list of the pod for me to trunk push the 3.1 please?
|
SreejaG
commented
Oct 17, 2019
|
@AlexLittlejohn Found the command to save you some time:
|
|
Sorry to bother you here with this @AlexLittlejohn, I don't have your e-mail address. |
|
@Tulleb , |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.





Tulleb commentedOct 13, 2019
•
edited
Check out the commits for more details. Main point of this fork is the iOS 13 compatibility: I fixed the cropping area resizing issue.
@AlexLittlejohn Please tell me if you want to go on with the support, I would be glad to provide more help and to remove my fork.
Meanwhile, people can also use the pod I made:
pod 'ALCameraViewController-Tulleb', '~> 3.1'