The Wayback Machine - https://web.archive.org/web/20200907132246/https://github.com/AlexLittlejohn/ALCameraViewController/pull/300
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported fork fixing iOS 13 issue #300

Merged
merged 26 commits into from Oct 16, 2019
Merged

Supported fork fixing iOS 13 issue #300

merged 26 commits into from Oct 16, 2019

Conversation

@Tulleb
Copy link
Collaborator

Tulleb commented Oct 13, 2019

Check out the commits for more details. Main point of this fork is the iOS 13 compatibility: I fixed the cropping area resizing issue.

@AlexLittlejohn Please tell me if you want to go on with the support, I would be glad to provide more help and to remove my fork.

Meanwhile, people can also use the pod I made:

pod 'ALCameraViewController-Tulleb', '~> 3.1'

@Tulleb Tulleb mentioned this pull request Oct 13, 2019
@Tulleb Tulleb changed the title Supported fork Supported fork fixing iOS 13 issue Oct 14, 2019
@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 15, 2019

I just received an invitation from @AlexLittlejohn to update this repo. I will do my best to take care of the support, thanks to him.

I will edit this MR to remove the new temporary pod repo, and add the fix you are talking about @SreejaG. Just give me a few days.

@AlexLittlejohn
Copy link
Owner

AlexLittlejohn commented Oct 15, 2019

Thank you for taking care of this, I've been super busy with home life such that i was not able to take care of this anymore

@SreejaG

This comment was marked as spam.

@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 16, 2019

@SreejaG Could you rewrite these into several issues please? I will take a look at them one by one. Feel free to submit new PR on your own also, it would go faster with some help :)

@SreejaG
Copy link

SreejaG commented Oct 16, 2019

Splitting the issues into 3 separate comments

First Issue:

Found an issue in iOS 13.1.2 :- iPhone
Camera is not loading after selecting cancel button in library section. This issue is not present in iOS version 12.

Steps:
Select the Photo library icon-> the screen shows a 'X' icon on top of the screen with a collection view of images-> Tap the close button-> the camera view shows a black screen.
Screenshot attached
66909447-67117200-f02a-11e9-885e-51d81ed65783
66909453-6aa4f900-f02a-11e9-8fa8-d9d3b19a4bdc
66909459-6d9fe980-f02a-11e9-8511-9ec40f572869

@SreejaG
Copy link

SreejaG commented Oct 16, 2019

Second Issue

Found issues in iOS 12.4 :- iPad

Selecting the tick icon in Confirm Screen directs to "Cancel button" action.
Solution: Update the constraints in the XIB file: "ConfirmViewController.Xib" for iPad.

@SreejaG
Copy link

SreejaG commented Oct 16, 2019

Third Issue

Found issue in iOS 12.4 :- iPad

The ICONs in camera screen is not aligned.
Screenshot attached
66909834-12222b80-f02b-11e9-9c21-cea56eb66613

@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 16, 2019

@SreejaG I meant creating issue through the issue tab which is designed for this: https://github.com/AlexLittlejohn/ALCameraViewController/issues

I will close this PR soon to replace it by another one, and your informations will be lost if you don't.

Thanks :)

@SreejaG
Copy link

SreejaG commented Oct 16, 2019

@Tulleb Tulleb self-assigned this Oct 16, 2019
@Tulleb Tulleb added this to the 3.1 milestone Oct 16, 2019
@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 16, 2019

Will add the issues on tomorrow

On Wed, 16 Oct, 2019, 6:57 PM Guillaume Bellut, @.***> wrote: @SreejaG https://github.com/SreejaG I meant creating issue through the issue tab which is designed for this: https://github.com/AlexLittlejohn/ALCameraViewController/issues I will close this PR soon to replace it by another one, and your informations will be lost if you don't. Thanks :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#300?email_source=notifications&email_token=AECS7ZDDDAUQODBF22BU46DQO4JDVA5CNFSM4JAHJHH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBMPDJY#issuecomment-542699943>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECS7ZAZK4XO5D4IW4KYBPDQO4JDVANCNFSM4JAHJHHQ .

Thanks: I will try to fix them next week through a 3.2 version.

@Tulleb Tulleb force-pushed the AlexLittlejohn:master branch 2 times, most recently from 3d556d8 to 2cd2215 Oct 16, 2019
@Tulleb Tulleb merged commit 6cc362d into AlexLittlejohn:master Oct 16, 2019
@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 16, 2019

@AlexLittlejohn Merge done. Could you also add me to the author list of the pod for me to trunk push the 3.1 please?

[!] You (guillaume@bellut.com) are not allowed to push new versions for this pod. The owners of this pod are alexlittlejohn@me.com.

@SreejaG
Copy link

SreejaG commented Oct 17, 2019

Added 2 separate issues in the issue section:
#303
#304

@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 18, 2019

@AlexLittlejohn Found the command to save you some time:

pod trunk add-owner ALCameraViewController guillaume@bellut.com

@Tulleb
Copy link
Collaborator Author

Tulleb commented Oct 23, 2019

Sorry to bother you here with this @AlexLittlejohn, I don't have your e-mail address.
I can't go further with the support if I can't push any update on the pod repository :(

@AlexLittlejohn
Copy link
Owner

AlexLittlejohn commented Oct 23, 2019

@Tulleb , incoming done. Apologies for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.