The Wayback Machine - https://web.archive.org/web/20200905052313/https://github.com/salesforce/TransmogrifAI/issues/287
Skip to content

/ TransmogrifAI

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Joda with Java 8 native Date Time #287

Open
wsuchy opened this issue Apr 16, 2019 · 2 comments · May be fixed by #329
Open

Replace Joda with Java 8 native Date Time #287

wsuchy opened this issue Apr 16, 2019 · 2 comments · May be fixed by #329
Labels
enhancement good first issue

Comments

@wsuchy
Copy link
Collaborator

@wsuchy wsuchy commented Apr 16, 2019

Problem
Since Java 8 was introduced there is no need to use Joda as it has been replaced the native Date-Time API.

Solution
Ideally greping and replacing the text should work (mostly)

Additional context
Need to check if de/serializing will still work.
@tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 16, 2019 •
edited

Nit: I think there is no cost for us to useit, since it might already be a spark transitive dependency. If no, then perhaps we can remove it.
@gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented May 16, 2019

quote from https://www.joda.org/joda-time/

Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.
@gerashegalov gerashegalov mentioned this issue May 17, 2019
Merged
@gerashegalov gerashegalov linked a pull request that will close this issue Jun 5, 2019
Open
@salesforce salesforce deleted a comment from Vizienteling948 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
3 participants
@tovbinm @gerashegalov @wsuchy
You can’t perform that action at this time.