The Wayback Machine - https://web.archive.org/web/20200904074544/https://github.com/Icinga/icinga2/issues/7630
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITL: Adding Extra-Opts to nagios plugins #7630

Open
netphantm opened this issue Nov 15, 2019 · 3 comments · May be fixed by #8010
Open

ITL: Adding Extra-Opts to nagios plugins #7630

netphantm opened this issue Nov 15, 2019 · 3 comments · May be fixed by #8010
Assignees

Comments

@netphantm
Copy link
Contributor

@netphantm netphantm commented Nov 15, 2019

I need to add Extra-Opts to check_http (https://www.monitoring-plugins.org/doc/extra-opts.html), as we are doing some checks through a proxy to check if host is reachable externally. A username/password combination is needed, so I included a file which contains the creds.
I added following lines to the command-plugins.conf:

    "--extra-opts" = {
          value = "$http_extra_opts$"
          description = "Add extra options to check (like proxy credentials file)"
    }

I wanted to extend the ITL with this, but then I realized that a lot of nagios plugins have this parameter. Should it be added to all of them manually or can you suggest a better way to do this?

@dnsmichi
Copy link
Contributor

@dnsmichi dnsmichi commented Nov 15, 2019

Preferably all CheckCommand definitions receive this parameter in a PR. Which is quite some effort to stem with the ITL changes and doc table updates.

@Al2Klimov
Copy link
Contributor

@Al2Klimov Al2Klimov commented May 12, 2020

Hello @netphantm and thank you for reporting!

Feel free to submit a PR with the affected CheckCommands. A lot of doesn't mean all.

And no, there's no better way to do this.

Best,
AK

@netphantm
Copy link
Contributor Author

@netphantm netphantm commented May 12, 2020

I will, I just had no time yet..

@Al2Klimov Al2Klimov removed the help wanted label May 12, 2020
netphantm pushed a commit to netphantm/icinga2 that referenced this issue May 14, 2020
add _extra_opts argument to plugins that support it

refs Icinga#7630
netphantm pushed a commit to netphantm/icinga2 that referenced this issue May 14, 2020
add _extra_opts argument to plugins that support it

refs Icinga#7630
netphantm pushed a commit to netphantm/icinga2 that referenced this issue May 14, 2020
add _extra_opts argument to plugins that support it

refs Icinga#7630
netphantm pushed a commit to netphantm/icinga2 that referenced this issue May 14, 2020
add --extra-opts argument to plugins that support it

refs Icinga#7630
netphantm pushed a commit to netphantm/icinga2 that referenced this issue May 14, 2020
add _extra_opts argument to plugins that support it

refs Icinga#7630
@netphantm netphantm linked a pull request that will close this issue May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.