Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Popular repositories
10,418 contributions in the last year
Activity overview
Contributed to
ArkEcosystem/platform-sdk,
ArkEcosystem/desktop-wallet,
ArkEcosystem/core
and 5 other
repositories
Contribution activity
August 2020
Created a pull request in ArkEcosystem/platform-sdk that received 1 comment
- feat(profiles): implement `DataRepository#first` and `DataRepository#last`
- chore: update dependencies
- feat(profiles): implement `Environment#registerCoin`
- fix(profiles): throw an exception if the ID of a newly signed transaction is a duplicate
- fix(profiles): only persist and restore known wallet data
- feat: verify that expected and actual sender of transactions are a match
- feat(profiles): persist signed and broadcasted transactions
- feat(profiles): implement `RegistrationAggregate`
- feat: implement `SignedTransactionData`
- feat(ark): implement AIP36
- chore: update dependencies
- chore(profiles): organise by domains
- feat(profiles): implement wallet transaction service
- feat: implement `TransactionData#isConfirmed`
- feat(profiles): implement public key to delegate mapper
- feat(profiles): expose data validator
- fix(profiles): ignore the name of contact that is being updated
- refactor(profile): pass query to transaction aggregate methods
- test(profiles): add tests for `Profile#getExchangeRate` and `Wallet#syncExchangeRate`
- test(profiles): add tests for coin proxy methods for `Wallet`
- test(profiles): add tests for `Profile`
- test(profiles): add tests for `TransactionAggregate`
- test(profiles): add tests for `LocalStorage`
- test(profiles): add tests for `CountAggregate`
- test(profiles): add tests for `ContactAddressRepository`
- Some pull requests not shown.
- refactor: use `SignedTransactionData` for transaction sent screen information
- chore: add AIP36 transaction support through SDK
- fix: avoid using raw transaction data
- chore: update Platform SDK dependencies
- feat: implement `HttpClient#withSocksProxy`
- chore: update Platform SDK dependencies
- chore: import all SDK packages
- refactor: include method and data in cache key
- feat: cache HTTP requests based on their URL
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- fix: send JSON headers to avoid malformed responses
- chore: add LSK to networks that can be selected
- chore: update Platform SDK dependencies
- refactor: pass `BigNumber` to `TotalAmountBox`
- refactor: format amount in `TransactionRow` with `BigNumber#toHuman`
- fix: respect query parameters for POST requests
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- ci: pass repository token to codecov action
- chore: update Platform SDK dependencies
- chore: update Platform SDK dependencies
- fix: select recipient field input
- feat: implement skeleton in transaction tables
- feat: load wallet from route for transaction send
- fix: windows builds
- chore: fix `Dropdown` scrollbar
- refactor: remove the required field icon for optional fields
- chore: upgrade storybook
- refactor: add the `openExternal()` electron to the `Link` component
- feat: add the `Completed` page after a successful import wallet
- feat: add electron util to open external links
- refactor: paginate wallet details transactions
- feat: add `ContactForm` address validations
- feat: transfer send functionality
- feat: add validation for duplicate address
- fix: electron build
- feat: implement offline splashscreen
- refactor: show required field icon by default
- chore: temporarily remove eth network data
- feat: add `InputAddress` component
- build: make all packages as external
- chore: update fixture data
- chore: add entity icon
- fix: align pending transactions
- fix: always add wallet icons cell in wallets table row
- ci: always update before installing new packages
- Some pull request reviews not shown.
Created an issue in ArkEcosystem/platform-sdk that received 1 comment
[Profiles] Apply peer settings of profile to new and existing wallets
A profile in the desktop wallet can have peer settings for each coin but they are not used at the moment. When a new wallet is created we should ch…
1
comment
- Persist signed and broadcasted transactions
- Store signed transactions as a DTO
- [NEO] Implement wallet balance
- [ARK] Add support for AIP36
- Validate that the transaction sender is the same as the wallet
- Expose address validation
- Support pagination for transaction aggregate
- [Profiles] Add remaining test coverage
- Finalise pagination implementation
- Implement pending transaction storage
400
contributions
in private repositories
Aug 1 – Aug 19

