The Wayback Machine - https://web.archive.org/web/20200907180916/https://github.com/testcontainers/testcontainers-java/issues/3129
Skip to content

/ testcontainers-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link in documentation #3129

Open
wlad opened this issue Aug 20, 2020 · 3 comments
Open

Dead link in documentation #3129

wlad opened this issue Aug 20, 2020 · 3 comments
Labels
good first issue help wanted

Comments

@wlad
Copy link

@wlad wlad commented Aug 20, 2020

here https://www.testcontainers.org/supported_docker_environment/

image
@wlad
Copy link
Author

@wlad wlad commented Aug 20, 2020 •
edited

this may be helpful for anybody who tries to open the broken link

https://github.com/testcontainers/testcontainers-java/blob/master/docs/supported_docker_environment/continuous_integration/circle_ci.md

Basically it says: don't use a docker executor! Instead use a machine executor.
@bsideup
Copy link
Member

@bsideup bsideup commented Aug 20, 2020

Hey @wlad,

I just marked the issue as "good first issue" in case someone is looking to contribute to the project.
@wpanas
Copy link
Contributor

@wpanas wpanas commented Aug 26, 2020

Hi @bsideup, I can take this one!
wpanas added a commit to wpanas/testcontainers-java that referenced this issue Aug 26, 2020
@wpanas
testcontainers#3129 Fix dead link for CircleCI configuration
2dd7917
rnorth pushed a commit that referenced this issue Aug 28, 2020
@wpanas
#3129 Fix dead link for CircleCI configuration (#3156)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c42c8ee 
Co-authored-by: wpanas <wpanas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted
3 participants
@bsideup @wpanas @wlad
You can’t perform that action at this time.