The Wayback Machine - https://web.archive.org/web/20200902013025/https://github.com/TheAlgorithms/Python/pull/2342
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization and fix bug #2342

Merged
merged 4 commits into from Aug 21, 2020
Merged

Optimization and fix bug #2342

merged 4 commits into from Aug 21, 2020

Conversation

@shellhub
Copy link
Member

shellhub commented Aug 20, 2020

Describe your change:

  • Optimization aliquot sum

  • fix bug in average_median.py

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shellhub and others added 2 commits Aug 20, 2020
@shellhub
* optimization aliquot_sum
650fe3a 
* fix bug in average_median
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
9ae483c
@shellhub shellhub requested a review from cclauss Aug 20, 2020
@cclauss
cclauss reviewed Aug 20, 2020
View changes
maths/average_median.py Outdated
@@ -6,6 +6,8 @@ def median(nums):
0
>>> median([4,1,3,2])
2.5
>>> median([2, 4, 6, 8, 20, 50, 70])

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 20, 2020 •
edited

Member

Better test if the values are not presorted?
@cclauss
cclauss approved these changes Aug 20, 2020
View changes
@shellhub
shellhub reviewed Aug 21, 2020
View changes
Copy link
Member Author

shellhub left a comment

Test using not presorted numbers
maths/average_median.py Outdated Show resolved Hide resolved
shellhub and others added 2 commits Aug 21, 2020
@shellhub
Update maths/average_median.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0f1f38f
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
4a10eeb
@shellhub shellhub merged commit 0591968 into TheAlgorithms:master Aug 21, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@shellhub @cclauss
You can’t perform that action at this time.