Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadded type hints to strings/min_cost_string_conversion.py #2337
Conversation
| @@ -9,7 +11,9 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| def compute_transform_tables(X, Y, cC, cR, cD, cI): | |||
| def compute_transform_tables( | |||
| X: str, Y: str, cC: int, cR: int, cD: int, cI: int | |||
This comment has been minimized.
This comment has been minimized.
cclauss
Aug 21, 2020
Member
Maybe it is just me but I hate these variable names. Uppercase characters are reserved for constants in Python and single letter and double letter variable names are so old school. They look kludgy in modern programming. Why make the caller/reader guess all the time?
This comment has been minimized.
This comment has been minimized.
| seq = [] | ||
| return seq |
Comment on lines
55
to
56
This comment has been minimized.
This comment has been minimized.
| first_string: str, | ||
| second_string: str, |
Comment on lines
15
to
16
This comment has been minimized.
This comment has been minimized.
cclauss
Aug 21, 2020
Member
Suggested change
| first_string: str, | |
| second_string: str, | |
| source_string: str, | |
| destination_string: str, |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Christian Clauss <[email protected]>
TravisBuddy
commented
Aug 21, 2020
|
Hey @Sonic0588, TravisCI finished with status TravisBuddy Request Identifier: 6650c3e0-e3bb-11ea-ae1e-a7d25f4a9615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Sonic0588 commentedAug 18, 2020
•
edited
Describe your change:
Added static type checking to min_cost_string_conversion.py towards issue #2128.
Checklist:
Fixes: #{$ISSUE_NO}.