The Wayback Machine - https://web.archive.org/web/20201129211642/https://github.com/u-wave/core/pull/406
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security tweaks #406

Merged
merged 5 commits into from Aug 27, 2020
Merged

Security tweaks #406

merged 5 commits into from Aug 27, 2020

Conversation

@goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Aug 26, 2020

  • Adds helmet for some basic xss protection and stuff.
  • Validates incoming WebSocket messages using ajv.
  • Use Map instead of plain objects in some places to reduce potential attack surface for prototype pollution
  • Use hasOwnProperty checks when parsing actions in the socket server so we don't try to call prototype functions (this could actually cause a crash)
@goto-bus-stop goto-bus-stop merged commit a90c3a9 into default Aug 27, 2020
3 checks passed
3 checks passed
LGTM analysis: JavaScript No new or fixed alerts
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@goto-bus-stop goto-bus-stop deleted the seclint branch Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.