The Wayback Machine - https://web.archive.org/web/20201018000814/https://github.com/edvin/tornadofx/issues/991
Skip to content

/ tornadofx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception in Application stop method in 1.7.19 #991

Closed
RazmikDev opened this issue May 14, 2019 · 2 comments
Closed

Exception in Application stop method in 1.7.19 #991

RazmikDev opened this issue May 14, 2019 · 2 comments

Comments

@RazmikDev
Copy link

@RazmikDev RazmikDev commented May 14, 2019 •
edited

Application with NoPrimaryViewSpecified as primaryView fails on shutdown (App.stop()) with following exception:

java.lang.RuntimeException: Exception in Application stop method
	at com.sun.javafx.application.LauncherImpl.launchApplication1(LauncherImpl.java:922)
	at com.sun.javafx.application.LauncherImpl.lambda$launchApplication$1(LauncherImpl.java:182)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalStateException: root.scene must not be null
	at tornadofx.UIComponent.unInit(Component.kt:575)
	at tornadofx.App.stop(App.kt:140)

that occurs here

tornadofx/src/main/java/tornadofx/Component.kt

Line 575 in e6258f0

root.scene.window.showingProperty().removeListener(rootSceneWindowShowingPropertyChangeListener)

Valid only for v1.7.19 - might be related with #973
@carltonwhitehead
Copy link
Contributor

@carltonwhitehead carltonwhitehead commented May 18, 2019

@RazmikDev I agree with your suspicion that it's related to #973. I made some adjustments including that line and didn't think to test NoPrimaryViewSpecified scenario. Sorry about that! I'll add a test for that scenario and fix the bug.
@edvin
Copy link
Owner

@edvin edvin commented May 18, 2019

Thank you @carltonwhitehead :)
@edvin edvin closed this in 69aa0a9 May 18, 2019
edvin pushed a commit that referenced this issue May 18, 2019
Edvin Syse
Merge pull request #995 from carltonwhitehead/991-fix-noprimaryviewsp…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e185f7 
…ecified

Fix NoPrimaryViewSpecified lifecycle issue, closes #991
edvin pushed a commit that referenced this issue Feb 17, 2020
Edvin Syse
- [#991](#1163): Workspace right drawer doesn't handle floating corre…
Loading status checks…
27ba781 
…ctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@edvin @carltonwhitehead @RazmikDev
You can’t perform that action at this time.