The Wayback Machine - https://web.archive.org/web/20200831055549/https://github.com/TheAlgorithms/Python/pull/2370
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additon of integers using LL #2370

Open
wants to merge 2 commits into
base: master
from
Open

additon of integers using LL #2370

wants to merge 2 commits into from
+81 −0

Conversation

@csendranshi
Copy link

csendranshi commented Aug 29, 2020

Describe your change:

Adding two integers of same length using Linked lists
Example add 321 + 248 = 569
(1)->(2)->(3) + (8)->(4)->(2) = (5)->(6)->(9)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@csendranshi
additon of integers using LL
Loading status checks…
6de7872
@TravisBuddy
Copy link

TravisBuddy commented Aug 29, 2020

Hey @csendranshi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d4a6c320-ea0b-11ea-9476-dd4d5d152bb6
@cclauss
Copy link
Member

cclauss commented Aug 29, 2020

Cool! Our linter is a bit picky about code style. The easiest way to fix these issues is:

  • mv addNodes.py add_nodes.py
  • python3 -m pip install black
  • black add_nodes.py
@csendranshi
formatted
Loading status checks…
1a803ab
@csendranshi
Copy link
Author

csendranshi commented Aug 29, 2020

Thanks for the guidance! I have executed the instructions.
@cclauss
cclauss requested changes Aug 29, 2020
View changes
data_structures/linked_list/add_nodes.py
self.head = None

# method to print the linked list
def printLL(self):

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 29, 2020 •
edited

Member

It is more Pythonic to define a .__str__() method that returns a str then then we can do print(my_linked_list).
data_structures/linked_list/add_nodes.py

# node definition
class Node:
def __init__(self, data):

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 29, 2020

Member

Please add Python type hints for function parameters as discussed in CONTRIBUTING.md.
data_structures/linked_list/add_nodes.py
temp = temp.next

# method to push a new node onto the linked list
def push(self, newdata):

This comment has been minimized.

Sign in to view
@cclauss

cclauss Aug 29, 2020

Member

Please add Python doctests for .push() and .add() as discussed in CONTRIBUTING.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@csendranshi @TravisBuddy @cclauss
You can’t perform that action at this time.