Add React and Hook config for ESLint #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innocentiv
requested review from
pacocoursey,
shuding and
Timer
as code owners
innocentiv
force-pushed
the
add_eslint_config_react
branch
from
f209905 to
4b794ec
Compare
innocentiv
force-pushed
the
add_eslint_config_react
branch
from
4b794ec to
f11742b
Compare
|
@innocentiv could you rebase please to increase the chance of a merge? |
innocentiv
force-pushed
the
add_eslint_config_react
branch
from
f11742b to
34d0f22
Compare
|
I have rebased this feature, updated the eslint plugins to the latest version, changed the rules to the recommended config from react docs (now they fixed the autofix on react-hooks/exhaustive-deps). I hope this suffices, but after seven months I have nome doubt 😄 |
shuding
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds eslint-plugin-react and eslint-plugin-react-hooks to the swr repository.
ESLint config extends plugin:react/recommended and add the react-hooks/rules-of-hooks rule as warning.
The use of useMemo after the early return in
if (config.suspense)is a violation of the rules of hooks and even if I do not expect config.suspense to change during the normal use of the library, I moved it above that piece of code. I think it is a safer approach. We could add and aneslint-disable-next-linecomment if you prefer.