The Wayback Machine - https://web.archive.org/web/20201010042833/https://github.com/ionic-team/ionic-framework/issues/21912
Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: scroll assist does not account for accessory bar #21912

Closed
dallastjames opened this issue Aug 12, 2020 · 2 comments
Closed

bug: scroll assist does not account for accessory bar #21912

dallastjames opened this issue Aug 12, 2020 · 2 comments
Labels
package: core type: bug
Milestone
5.3.2

Comments

@dallastjames
Copy link

@dallastjames dallastjames commented Aug 12, 2020 •
edited

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:

Scroll assist calculation appears to be off when running on an iOS device with a notch. The screen does scroll correctly, but seems to come up short by about the size of the notch. The behavior is correct when running the app using Capacitor, and is only present on an iOS device with a notch when using Cordova. (Checked on simulator against iPhone 11 and Xr, which have the notch, vs the SE gen2 which does not have the notch)

Expected behavior:

The scroll assist correctly calculates the adjustment on devices with the notch.

Steps to reproduce:

REPO: https://github.com/dallastjames/ionic-cordova-keyboard-autoscroll-bug

npm i
ionic cordova build ios

Ionic info:

@ionic/angular 5.3.1
@ionitron-bot ionitron-bot bot added the triage label Aug 12, 2020
@liamdebeasi liamdebeasi changed the title Scroll Assist issue on iOS device with notch on Cordova bug: scroll assist does not account for accessory bar Aug 13, 2020
@liamdebeasi liamdebeasi added this to the 5.3.2 milestone Aug 13, 2020
@ionitron-bot ionitron-bot bot removed triage labels Aug 13, 2020
brandyscarney added a commit that referenced this issue Aug 19, 2020
@brandyscarney
fix(input): adjust scroll to include the accessory bar on iOS
Loading status checks…
e579ed9 
fixes #21912
@brandyscarney brandyscarney mentioned this issue Aug 19, 2020
Merged
3 of 13 tasks complete
@dallastjames
Copy link
Author

@dallastjames dallastjames commented Aug 24, 2020 •
edited

Tested this against version 5.4.0-dev.202008192028.e579ed9 which did fix this demo, but I was able to replicate the issue again by adding tabs to the application. The demo was updated to include an option to render the page within a tabs container. When rendered inside of the tabs container, the fixed-label input element shows the issue again on ios device when running on cordova
brandyscarney added a commit that referenced this issue Aug 27, 2020
@brandyscarney @liamdebeasi
fix(input): improve reliability of scroll assist when accessory bar i…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22477fb 
…s enabled (#21936)

fixes #21912

Co-authored-by: Liam DeBeasi <liamdebeasi@icloud.com>
@ionitron-bot
Copy link

@ionitron-bot ionitron-bot bot commented Sep 26, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core type: bug
2 participants
@liamdebeasi @dallastjames
You can’t perform that action at this time.