The Wayback Machine - https://web.archive.org/web/20201016014520/https://github.com/pkgjs/wiby/pull/25
Skip to content

/ wiby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI #25

Merged
merged 5 commits into from Aug 10, 2020
Merged

Update CI #25

merged 5 commits into from Aug 10, 2020

Conversation

@rodion-arr
Copy link
Member

@rodion-arr rodion-arr commented Aug 3, 2020

  • Add separate lint and test-only npm scripts
  • Update CI to run lint once and then run tests on matrix

Closes #18
@rodion-arr rodion-arr requested review from ljharb and dominykas Aug 3, 2020
@rodion-arr
Copy link
Member Author

@rodion-arr rodion-arr commented Aug 3, 2020

Hm.. strange, standard is passing locally but failed on CI.. will take a look
@rodion-arr
Update CI
Loading status checks…
75db538 
- Add separate lint and test-only scripts
- Update CI to run lint once and then run tests on matrix
@rodion-arr
Copy link
Member Author

@rodion-arr rodion-arr commented Aug 3, 2020

I wasn't rebased on latest upstream. Linting on master is failing
@rodion-arr rodion-arr force-pushed the rodion-arr:reconfigure-ci branch from a944323 to 75db538 Aug 3, 2020
@rodion-arr
Fix CLI commands configuration
Loading status checks…
8eb68d7
@dominykas
dominykas reviewed Aug 3, 2020
View changes
bin/wiby.js Show resolved Hide resolved
@dominykas
dominykas reviewed Aug 3, 2020
View changes
.travis.yml Show resolved Hide resolved
rodion-arr and others added 2 commits Aug 3, 2020
@rodion-arr @dominykas
Update bin/wiby.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b8d1c1b 
Co-authored-by: Dominykas Blyžė <hello@dominykas.com>
@rodion-arr
Include lint job into matrix instead of excluding from version list
Loading status checks…
b8f63d8
@rodion-arr rodion-arr requested a review from dominykas Aug 3, 2020
@ljharb
ljharb approved these changes Aug 3, 2020
View changes
.travis.yml Outdated Show resolved Hide resolved
@rodion-arr @ljharb
Update .travis.yml
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c9a0c64 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@rodion-arr rodion-arr mentioned this pull request Aug 3, 2020
Closed
@dominykas
dominykas approved these changes Aug 4, 2020
View changes
@BethGriggs
BethGriggs approved these changes Aug 4, 2020
View changes
@dominykas dominykas merged commit 1a3b912 into pkgjs:master Aug 10, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@rodion-arr rodion-arr deleted the rodion-arr:reconfigure-ci branch Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@rodion-arr @ljharb @dominykas @BethGriggs
You can’t perform that action at this time.