The Wayback Machine - https://web.archive.org/web/20200920054043/https://github.com/segmentio/evergreen/issues/940
Skip to content

/ evergreen

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: className props not added to Dialog component #940

Closed
Valentindi opened this issue Aug 17, 2020 · 2 comments
Closed

Dialog: className props not added to Dialog component #940

Valentindi opened this issue Aug 17, 2020 · 2 comments

Comments

@Valentindi
Copy link

@Valentindi Valentindi commented Aug 17, 2020

Hey, thanks for this great work.

In the last days I was writing some test cases, I encountered the problem that class names added to the dialog component are not rendered.
Did you implement this on purpose? If not, it would make it much easier for me to develop.

Thanks
@akleiner2
Copy link
Contributor

@akleiner2 akleiner2 commented Aug 17, 2020

@Valentindi The <Dialog /> component is broken up into an overlay and the actual dialog container. Depending on which you're trying to add a className to, you probably want <Dialog containerProps={{ className: 'your-css-class-here' }} ... /> or <Dialog overlayProps={{ className: 'your-css-class-here' }} ... />. Let me know if this works!
@akleiner2
Copy link
Contributor

@akleiner2 akleiner2 commented Aug 27, 2020

Hey @Valentindi going to close this out - but let me know if you still see issues with the proposed solution!
@akleiner2 akleiner2 closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@akleiner2 @Valentindi
You can’t perform that action at this time.