The Wayback Machine - https://web.archive.org/web/20201001004759/https://github.com/GoogleChrome/lighthouse-ci/pull/396
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysql support to docker-server #396

Merged
merged 1 commit into from Aug 3, 2020
Merged

Conversation

@amaralv
Copy link
Contributor

@amaralv amaralv commented Aug 3, 2020

No description provided.

@googlebot
Copy link

@googlebot googlebot commented Aug 3, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

thanks @amaralv !

would you mind signing the CLA to make @googlebot happy :)

@amaralv
Copy link
Contributor Author

@amaralv amaralv commented Aug 3, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot
Copy link

@googlebot googlebot commented Aug 3, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@amaralv
Copy link
Contributor Author

@amaralv amaralv commented Aug 3, 2020

@googlebot I fixed it.

@amaralv amaralv force-pushed the amaralv:master branch from 74608d3 to 7201c88 Aug 3, 2020
@googlebot
Copy link

@googlebot googlebot commented Aug 3, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@patrickhulce patrickhulce merged commit 0474934 into GoogleChrome:master Aug 3, 2020
4 of 5 checks passed
4 of 5 checks passed
Windows
Details
macOS
Details
Linux Linux
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amaralv
Copy link
Contributor Author

@amaralv amaralv commented Aug 4, 2020

@patrickhulce can we have a new version of docker image with this changes?
Thanks :)

@patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Aug 4, 2020

0.4.4 should have it :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.