The Wayback Machine - https://web.archive.org/web/20201116034303/https://github.com/google/wire/pull/236
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/wire: fix panic in objectCache.processExpr #236

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@dmitris
Copy link
Contributor

@dmitris dmitris commented Jan 8, 2020

PR fixes the panic that I've seen with some "edge case" configurations due to using a nil object in a compound "chain" of functions calls (unfortunately, didn't save a reproducible sample).

@go-cloud-bot
Copy link

@go-cloud-bot go-cloud-bot bot commented Jan 8, 2020

Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change.

@googlebot googlebot added the cla: yes label Jan 8, 2020
@dmitris dmitris changed the title fix panic in objectCache.processExpr internal/wire: fix panic in objectCache.processExpr Jan 8, 2020
@dmitris dmitris force-pushed the dmitris:fix-panic branch from 5469061 to 4c86c0c Jan 8, 2020
internal/wire/parse.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shantuo shantuo left a comment

Thanks!

@shantuo shantuo merged commit fda1135 into google:master Jan 10, 2020
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch 16.66% of diff hit (target 0%)
Details
codecov/project 61.66% (target 0%)
Details
@dmitris dmitris deleted the dmitris:fix-panic branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.