The Wayback Machine - https://web.archive.org/web/20201119002014/https://github.com/getify/Functional-Light-JS/issues/180
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tag not closing #180

Open
xorob0 opened this issue Apr 4, 2019 · 3 comments
Open

Image tag not closing #180

xorob0 opened this issue Apr 4, 2019 · 3 comments

Comments

@xorob0
Copy link

@xorob0 xorob0 commented Apr 4, 2019

Yes, I promise I've read the Contributions Guidelines (please feel free to remove this line -- if you leave this line here, I'm going to assume you didn't actually read it).

Some reader don't like that the img tag are not closed. I would advise changing this :

<p align="center">
    <img src="images/fig1.png" width="40%">
</p>

to this :

<p align="center">
    <img src="images/fig1.png" width="40%"/>
</p>

on every images.
I can do a the PR if you want me to, but maybe there is a reason for that that I do not understand.

@getify
Copy link
Owner

@getify getify commented Apr 4, 2019

Some reader don't like that the img tag are not closed

Why?

@xorob0
Copy link
Author

@xorob0 xorob0 commented Apr 4, 2019

If you try converting them to XHTML (for ePub for exemple) you need the self-closing tag because it is in the XHTML specifications it is needed (see https://www.w3schools.com/tags/tag_img.asp)
My kobo e-reader really doesn't like that the tag is not closed and just skips the rest of the chapter...

@getify
Copy link
Owner

@getify getify commented Apr 4, 2019

Interesting... I wonder why the epub that is generated from Leanpub works fine. Maybe they're correcting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.