The Wayback Machine - https://web.archive.org/web/20210121024608/https://github.com/rstudio/revealjs/pull/75
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add md_extensions option #75

Merged
merged 2 commits into from Mar 2, 2020
Merged

Add md_extensions option #75

merged 2 commits into from Mar 2, 2020

Conversation

@atusy
Copy link

@atusy atusy commented Feb 14, 2020

To improve consistency with other formats (e.g., rmarkdown::html_document)

@atusy
Copy link
Author

@atusy atusy commented Feb 14, 2020

Forgotten to mention this PR closes #68

from = rmarkdown_format(ifelse(fig_caption,
"",
"-implicit_figures")),
from = rmarkdown_format(paste0(

This comment has been minimized.

@jjallaire

jjallaire Feb 14, 2020
Member

Let's do this the same way that slidy_presentation does (https://github.com/rstudio/rmarkdown/blob/07b238ceee3aa428acdfbb7351c1cfd9ae48e3f7/R/slidy_presentation.R#L95). Basically chain it together with smart then pass the result (along with fig_caption) to from_rmarkdown

This comment has been minimized.

@atusy

atusy Feb 15, 2020
Author

Alright. Do we check Pandoc's version > 2.0 as slidy_presentation does?
For the smart option, revealjs_presentation does not check it, but slidy_presentation does.
Unfortunately, rmarkdown package does not export smart_extiensions nor pandoc2.0.

This comment has been minimized.

@jjallaire

jjallaire Feb 17, 2020
Member

I don't think we need to do the v2.0 check.

This comment has been minimized.

@atusy

atusy Mar 1, 2020
Author

Recently, I noticed that the smart option is meaningless.
Maybe it is a choice for revealjs_presentation to drop the smart option for the better connection with Pandoc.
rstudio/rmarkdown#1774

@jjallaire jjallaire merged commit 8127870 into rstudio:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.