The Wayback Machine - https://web.archive.org/web/20200813050312/https://github.com/servo/bincode/issues/341
Skip to content

/ bincode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`WithOtherTrailing` and `WithOtherIntEncoding` are not `Copy` / `Clone` #341

Closed
luben opened this issue Jul 20, 2020 · 1 comment
Closed

`WithOtherTrailing` and `WithOtherIntEncoding` are not `Copy` / `Clone` #341

luben opened this issue Jul 20, 2020 · 1 comment

Comments

@luben
Copy link
Contributor

@luben luben commented Jul 20, 2020

Is there a reason for WithOtherTrailing and WithOtherIntEncoding not being Copy/Clone as the other Options ?
@ZoeyR
Copy link
Collaborator

@ZoeyR ZoeyR commented Jul 20, 2020

No reason. Looks like an oversight.
luben added a commit to luben/bincode that referenced this issue Jul 20, 2020
@luben
Fix `WithOtherTrailing` and `WithOtherIntEncoding`
70907f0 
They should be Copy/Clone as the rest of the Options

Closes servo#341
@luben luben mentioned this issue Jul 20, 2020
Merged
@ZoeyR ZoeyR closed this in #342 Jul 20, 2020
ZoeyR pushed a commit that referenced this issue Jul 20, 2020
@luben
Fix `WithOtherTrailing` and `WithOtherIntEncoding` (#342)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c393171 
They should be Copy/Clone as the rest of the Options

Closes #341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@luben @ZoeyR
You can’t perform that action at this time.