The Wayback Machine - https://web.archive.org/web/20201013221835/https://github.com/angular/components/pull/19953
Skip to content

/ components

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(grid-list): remove circular dependencies #19953

Merged
merged 1 commit into from Jul 17, 2020
Merged

refactor(grid-list): remove circular dependencies #19953

merged 1 commit into from Jul 17, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 12, 2020

Changes some types in order to avoid a circular dependency between the grid list and the tile styler.
@crisbeto
refactor(grid-list): remove circular dependencies
Loading status checks…
d0fb933 
Changes some types in order to avoid a circular dependency between the grid list and the tile styler.
@crisbeto crisbeto requested review from jelbourn and angular/dev-infra-components as code owners Jul 12, 2020
@googlebot googlebot added the cla: yes label Jul 12, 2020
@devversion
devversion approved these changes Jul 13, 2020
View changes
Copy link
Member

@devversion devversion left a comment

LGTM
@jelbourn
jelbourn approved these changes Jul 13, 2020
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM
@andrewseguin andrewseguin merged commit dbbe2f2 into angular:master Jul 17, 2020
15 checks passed
15 checks passed
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
andrewseguin added a commit that referenced this pull request Jul 17, 2020
@crisbeto @andrewseguin
refactor(grid-list): remove circular dependencies (#19953)
Loading status checks…
5700726 
Changes some types in order to avoid a circular dependency between the grid list and the tile styler.

(cherry picked from commit dbbe2f2)
ngwattcos added a commit to ngwattcos/components that referenced this pull request Jul 20, 2020
@crisbeto @ngwattcos
refactor(grid-list): remove circular dependencies (angular#19953)
918eae9 
Changes some types in order to avoid a circular dependency between the grid list and the tile styler.
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Aug 17, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.
@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 cla: yes merge ready merge safe target: patch
5 participants
@crisbeto @jelbourn @devversion @googlebot @andrewseguin
You can’t perform that action at this time.