It is unclear from the provided documentation what the difference is between a chunk and a subbuffer. Without examples it can be very difficult to identify when using one instead of the other may be necessary. We spent multiple days tracking down why an attempt to pass a subbuffer of vertices to a call to draw() was failing to compile. The error message was extremely verbose, but ultimately see

Hi guys. Is there any documentation for the methods found in ShaderLang.h?
For example,what does TShader::setInvertY do?
I have just started so pretty sure I am going to have more questions related to the API.

The parsers for floating point number are especially bad as they allocate memory. See #113 for further details.

The for-loop creates redundant instructions in the instructions of checking exit condition.

ex)

kernel void loop1 (global float a[], global float b[]) {
  for (int i = 0; i < 1000; i++) {
    a[i] = -i;
    b[i] = -i;
  }
}

// Module with 1 kernels, global data with 0 words (64-bit each), starting at offset 1 words and 0 words of stack-frame
// Kernel 'loop1' with 67

Some functions (especially simple getter-like functions) could probably avoid returning a Result and simply return the type, because we don't actually expect exceptions to be thrown on the C++ side.

As well, reconsider ErrorCode. Perhaps a String is sufficient for these cases and we can avoid the enum altogether.

Old code: https://github.com/Vengarioth/xshade/blob/master/src/type_system/type_check.rs#L94-L124

• Create a pass in passes/ast/type_checking
• Add function type to symbol table
• Add function as symbol to the symbol table
• Type check arguments
• Type check return type (not if it actually returns the correct type)
• Set call signature for function type
• Test

Right now it is not clear which benchmarks are new, and which are ports of existing benchmarks. We should add notes in each benchmark source file, referring to the original source, if there is any.