The Wayback Machine - https://web.archive.org/web/20201219044443/https://github.com/ssloy/tinyrenderer/pull/42
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faults in Make builds #42

Merged
merged 1 commit into from Jan 7, 2020
Merged

Fix faults in Make builds #42

merged 1 commit into from Jan 7, 2020

Conversation

@theosotr
Copy link
Contributor

@theosotr theosotr commented Jan 4, 2020

Hello

This pull request improves the build script of this project.
Specifically, it adds missing Make dependencies so that the targets of the project are re-generated correctly whenever there are updates to any of the dependent source files.

In this way, the project is incrementally built.

Note that this fix follows the best practices for tracking dependencies automatically (through gcc -MD)

For more details, see here.
https://www.gnu.org/software/make/manual/html_node/Automatic-Prerequisites.html

@theosotr theosotr force-pushed the theosotr:fix branch from d39bf81 to 74119ce Jan 4, 2020
@ssloy ssloy merged commit f5faf0b into ssloy:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.