Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate clmtrackr w/ git auto-update #308
Conversation
|
Hmm, the CI shouldn't fail if the file already exists. |
|
Agreed |
|
Thanks :) |
|
The switch to NPM was done on purpose, as checking for newer versions
should be faster (a few (one?) http call vs git clone). Don't we want that? :)
…On 5. juli 2020 16.06.25 "Matt (IPv4) Cowley" ***@***.***> wrote:
@MattIPv4 requested changes on this pull request.
Thanks :)
In packages/c/clmtrackr.json:
> + "source": "npm",
+ "target": "clmtrackr",
|
|
We discussed this internally -- unless we need to switch to make the package work, we'd much prefer to stay with the original source that the author chose for auto-updating. We don't have insight into why they chose Git over NPM, but there may be a reason. It also reduces the changes in the diff & reduces the risk of switching to an incorrect package, which has happened in a couple of the other PRs. |
|
Fair enough :) Should we update the doc and state that NPM is preferred? BTW: Do you use a tool to generate the glob url? |
Co-authored-by: Matt (IPv4) Cowley <me@mattcowley.co.uk>
I don't think so, we're happy with either being used. Git cloning is a bit slower for sure, but that's not our biggest worry really. I'm happy for folks to add packages with either as a source.
I built https://www.digitalocean.com/community/tools/glob a while back for testing globs easily on cdnjs, and even added a feature to quickly pull in files from an NPM package to make the whole process that much faster. The CI generates glob URLs that go to that tool as well. |
MattIPv4
changed the title
|
Lgtm, thanks! |
klausenbusk commentedJul 4, 2020
The auto-update glob is out-of-date, so let's switch to NPM and fix the
glob.
Refs #302