The Wayback Machine - https://web.archive.org/web/20221223154532/https://github.com/python/cpython/pull/21570
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40741: Update Windows build to include SQLite 3.32.3 #21570

Merged
merged 2 commits into from Jul 20, 2020
Merged

bpo-40741: Update Windows build to include SQLite 3.32.3 #21570

merged 2 commits into from Jul 20, 2020

Conversation

zooba
Copy link
Member

@zooba zooba commented Jul 20, 2020 •
edited by bedevere-bot

@zooba zooba requested a review from a team as a code owner Jul 20, 2020
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jul 20, 2020 •
edited

You missed the comment in PCbuild/readme.txt (around line 185-ish):

diff --git a/PCbuild/readme.txt b/PCbuild/readme.txt
index 4d4a706b8e..b8849757e8 100644
--- a/PCbuild/readme.txt
+++ b/PCbuild/readme.txt
@@ -185,7 +185,7 @@ _ssl
     again when building.
 
 _sqlite3
-    Wraps SQLite 3.31.1.0, which is itself built by sqlite3.vcxproj
+    Wraps SQLite 3.32.3.0, which is itself built by sqlite3.vcxproj
     Homepage:
         http://www.sqlite.org/
 _tkinter
@zooba zooba merged commit 84761c3 into python:master Jul 20, 2020
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 20, 2020

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
@zooba
Copy link
Member Author

zooba commented Jul 20, 2020

macOS changes appeared to be in the process of timing out, and it's unaffected by this change anyway, so merging.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@zooba @miss-islington
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
7f1823d 
)

(cherry picked from commit 84761c3)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2020

GH-21571 is a backport of this pull request to the 3.9 branch.
@zooba zooba deleted the bpo-40741 branch Jul 20, 2020
@bedevere-bot
Copy link

bedevere-bot commented Jul 20, 2020

GH-21572 is a backport of this pull request to the 3.8 branch.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2020
@zooba @miss-islington
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
e2dc6f7 
)

(cherry picked from commit 84761c3)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Jul 21, 2020
@miss-islington @zooba
bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570)
f599f9e 
(cherry picked from commit 84761c3)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Jul 21, 2020
@miss-islington @zooba
bpo-40741: Update Windows build to include SQLite 3.32.3 (GH-21570)
d6ba8c8 
(cherry picked from commit 84761c3)

Co-authored-by: Steve Dower <steve.dower@python.org>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@zooba @arun-mani-j
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
76519cf 
)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@zooba @shihai1991
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
ccbc2bc 
)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@zooba @shihai1991
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
48e637f 
)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@zooba
bpo-40741: Update Windows build to include SQLite 3.32.3 (pythonGH-21570
65dce95 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-windows
5 participants
@zooba @erlend-aasland @miss-islington @bedevere-bot @the-knights-who-say-ni