Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Code intended for the service worker is run on web page in dev mode #131
Assignees
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code in https://github.com/vuejs-templates/pwa/blob/development/template/build/service-worker-dev.js is meant to be the content of a service worker file, and will only run as expected if inside of the
ServiceWorkerGlobalScope.However, as part of the
devwebpack build, it ends up being inlined inside ofindex.html, meaning that it will run (and do nothing) inside theWindowClient(i.e. web page) scope.pwa/template/build/webpack.dev.conf.js
Lines 36 to 38 in 694af84
Instead of taking
service-worker-dev.jsand inlining it inside ofindex.html, the same service worker registration code can be used in bothdevandprod, with the difference between to the two environments being the actual contents of theservice-worker.jsfile.In
dev, theservice-worker.jsfile should contain what's currently in[service-worker-dev.js](https://github.com/vuejs-templates/pwa/blob/development/template/build/service-worker-dev.js).In
prod, theservice-worker.jsfile should contain the generated output ofSWPrecachePlugin.